test(rsc): tweak timeout #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
It has been flaky with rolldown. I'm suspecting this is because it puts more pressure on CI resource and running tests in parallel (currently
workers: 2) makes browser slower.Solution
This PR tweaks flaky assertion's timeout and also tweaked recording options https://playwright.dev/docs/test-use-options#recording-options to improve debugging.
After thought
Actually the issue seems different. The error is actually not during
waitForHydrationpolling, but it just errors out on firstpage.locator(locator).evaluate(...)call.Also "Console" and "Network" trace suggest there's indeed a full reload somehow:
screenshots
Well, actually this is not the case for the trace from different failures https://github.com/vitejs/vite-plugin-react/actions/runs/17721044144/job/50353326025, so the cause is still unclear. Anyways, let's merge this one for now.