Skip to content

test(rsc): tweak timeout #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

test(rsc): tweak timeout #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30d5d50
test(rsc): tweak timeout
hi-ogawa Sep 15, 2025
0f79549
test: tweak trace
hi-ogawa Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/plugin-rsc/e2e/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
() =>
page
.locator(locator)
.evaluate(

Check failure on line 13 in packages/plugin-rsc/e2e/helper.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (rolldown)

[chromium] › e2e/basic.test.ts:203:3 › dev-default › basic 

  2) [chromium] › e2e/basic.test.ts:203:3 › dev-default › basic › Expect "poll toBeTruthy" ─────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: locator.evaluate: Execution context was destroyed, most likely because of a navigation

       at helper.ts:13

      11 |         page
      12 |           .locator(locator)
    > 13 |           .evaluate(
         |            ^
      14 |             (el) =>
      15 |               el &&
      16 |               Object.keys(el).some((key) => key.startsWith('__reactFiber')),
        at Object.expect.poll.timeout (/home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/helper.ts:13:12)

Check failure on line 13 in packages/plugin-rsc/e2e/helper.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (rolldown)

[chromium] › e2e/basic.test.ts:203:3 › dev-default › basic 

  2) [chromium] › e2e/basic.test.ts:203:3 › dev-default › basic › Expect "poll toBeTruthy" ─────────
    Error: locator.evaluate: Execution context was destroyed, most likely because of a navigation

       at helper.ts:13

      11 |         page
      12 |           .locator(locator)
    > 13 |           .evaluate(
         |            ^
      14 |             (el) =>
      15 |               el &&
      16 |               Object.keys(el).some((key) => key.startsWith('__reactFiber')),
        at Object.expect.poll.timeout (/home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/helper.ts:13:12)

Check failure on line 13 in packages/plugin-rsc/e2e/helper.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (rolldown)

[chromium] › e2e/starter.ts:20:3 › dev-base › basic 

  1) [chromium] › e2e/starter.ts:20:3 › dev-base › basic › Expect "poll toBeTruthy" ────────────────
    Error: locator.evaluate: Execution context was destroyed, most likely because of a navigation

       at helper.ts:13

      11 |         page
      12 |           .locator(locator)
    > 13 |           .evaluate(
         |            ^
      14 |             (el) =>
      15 |               el &&
      16 |               Object.keys(el).some((key) => key.startsWith('__reactFiber')),
        at Object.expect.poll.timeout (/home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/helper.ts:13:12)
(el) =>
el &&
Object.keys(el).some((key) => key.startsWith('__reactFiber')),
),
{ timeout: 10000 },
{ timeout: 20000 },
)
.toBeTruthy()
}
Expand Down
3 changes: 2 additions & 1 deletion packages/plugin-rsc/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import { defineConfig, devices } from '@playwright/test'
export default defineConfig({
testDir: 'e2e',
use: {
trace: 'on-first-retry',
screenshot: 'only-on-failure',
trace: 'on-all-retries',
},
expect: {
toPass: { timeout: 10000 },
Expand Down
Loading