fix(config): resolve implicit deps as absolute path #10254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need this to fix |
9 tasks
patak-dev
reviewed
Oct 3, 2022
packages/vite/src/node/config.ts
Outdated
| if (id[0] !== '.' && !isAbsolute(id)) { | ||
| const idFsPath = tryNodeResolve(id, importer, options, false)?.id | ||
| const idPath = | ||
| isESM && idFsPath ? pathToFileURL(idFsPath).href : idFsPath |
There was a problem hiding this comment.
@antfu could Windows be complaining because idFsPath is now normalized? In the current code it isn't. I don't think this should affect though.
bluwy
approved these changes
Oct 3, 2022
patak-dev
approved these changes
Oct 3, 2022
|
Nice fix @bluwy! |
antfu
added a commit
that referenced
this pull request
Oct 3, 2022
Co-authored-by: BjornLuG <bjornlu.dev@gmail.com>
9 tasks
7 tasks
This was referenced Oct 11, 2022
This was referenced Oct 17, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #9202, revert #9140
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).