-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release docs: Add vreplication related entries to the v20 summary #16259
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Support for multi-tenant imports has been added to `MoveTables`. If you have a multi-tenant architecture where each | ||
tenant has their own database, you can import the tenants using multiple `MoveTables` workfows, one per tenant. | ||
Each import is initiated with the new `--tenant-id` flag. The column name (and data type) need to be specified in | ||
the VSchema of the target keyspace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a side note that we should add something in the docs that includes an example usage of the flag:
--tenant-id string (EXPERIMENTAL: Multi-tenant migrations only) The tenant ID to use for the MoveTables workflow into a multi-tenant keyspace.
As it's not entirely clear in the flag output that this is supposed to be a column reference from the vschema. Perhaps best to just document that in the flag's help output directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to change release_notes.md
on the release-20.0-rc
backport
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16259 +/- ##
==========================================
- Coverage 68.60% 68.59% -0.01%
==========================================
Files 1544 1544
Lines 197988 198018 +30
==========================================
+ Hits 135825 135836 +11
- Misses 62163 62182 +19 ☔ View full report in Codecov by Sentry. |
…6259) Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…6259) Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Description
Adds VReplication section and entries to v20 summary doc.
Related Issue(s)
Checklist