fix(consistent-test-it): Handle aliased Vitest imports when enforcing consistent test names (#828)

* test: add test

* fix: improve import specifier handling in fixer

Author: y-hsgw

src/rules/consistent-test-it.ts

@@ -86,6 +86,7 @@ export default createEslintRule<
     const testKeywordWithinDescribe = withinDescribe || fn || TestCaseName.it
     const testFnDisabled =
       testFnKeyWork === testKeywordWithinDescribe ? testFnKeyWork : undefined
+    const { sourceCode } = context
 
     let describeNestingLevel = 0
 
@@ -99,33 +100,43 @@ export default createEslintRule<
         for (const specifier of node.specifiers) {
           if (specifier.type !== 'ImportSpecifier') continue
           if (specifier.imported.type !== 'Identifier') continue
-          if (specifier.local.name !== specifier.imported.name) continue
-          if (specifier.local.name === oppositeTestKeyword) {
-            context.report({
-              node: specifier,
-              data: { testFnKeyWork, oppositeTestKeyword },
-              messageId: 'consistentMethod',
-              fix: (fixer) => {
-                const remainingSpecifiers = node.specifiers.filter(
-                  (spec) => spec.local.name !== oppositeTestKeyword,
+          if (specifier.imported.name !== oppositeTestKeyword) continue
+
+          context.report({
+            node: specifier,
+            data: { testFnKeyWork, oppositeTestKeyword },
+            messageId: 'consistentMethod',
+            fix: (fixer) => {
+              const remainingSpecifiers = node.specifiers.filter(
+                (spec) => spec !== specifier,
+              )
+              if (remainingSpecifiers.length > 0) {
+                const hasPreferredSpecifier = remainingSpecifiers.some(
+                  (spec) =>
+                    spec.type === AST_NODE_TYPES.ImportSpecifier &&
+                    spec.imported.type === AST_NODE_TYPES.Identifier &&
+                    spec.imported.name === testFnDisabled,
+                )
+                const importNames = remainingSpecifiers.map((spec) =>
+                  sourceCode.getText(spec),
                 )
-                if (remainingSpecifiers.length > 0) {
-                  const importText = remainingSpecifiers
-                    .map((spec) => spec.local.name)
-                    .join(', ')
-                  const lastSpecifierRange = node.specifiers.at(-1)?.range
-                  if (!lastSpecifierRange) return null
-
-                  return fixer.replaceTextRange(
-                    [node.specifiers[0].range[0], lastSpecifierRange[1]],
-                    importText,
-                  )
+                if (!hasPreferredSpecifier) {
+                  importNames.push(testFnDisabled)
                 }
 
-                return fixer.replaceText(specifier.local, testFnDisabled)
-              },
-            })
-          }
+                const importText = importNames.join(', ')
+                const lastSpecifierRange = node.specifiers.at(-1)?.range
+                if (!lastSpecifierRange) return null
+
+                return fixer.replaceTextRange(
+                  [node.specifiers[0].range[0], lastSpecifierRange[1]],
+                  importText,
+                )
+              }
+
+              return fixer.replaceText(specifier, testFnDisabled)
+            },
+          })
         }
       },
       CallExpression(node: TSESTree.CallExpression) {

tests/consistent-test-it.test.ts

@@ -322,13 +322,36 @@ ruleTester.run(RULE_NAME, rule, {
             testFnKeyWork: TestCaseName.test,
             oppositeTestKeyword: TestCaseName.it,
           },
+          line: 1,
+          column: 10,
+          endColumn: 12,
         },
         {
           messageId: 'consistentMethod',
           data: {
             testFnKeyWork: TestCaseName.test,
             oppositeTestKeyword: TestCaseName.it,
           },
+          line: 2,
+          column: 1,
+          endColumn: 3,
+        },
+      ],
+    },
+    {
+      code: 'import { it as baseIt, test } from "vitest"\nbaseIt("foo")',
+      output: 'import { it as baseIt } from "vitest"\nbaseIt("foo")',
+      options: [{ fn: TestCaseName.it }],
+      errors: [
+        {
+          messageId: 'consistentMethod',
+          data: {
+            testFnKeyWork: TestCaseName.it,
+            oppositeTestKeyword: TestCaseName.test,
+          },
+          column: 24,
+          endColumn: 28,
+          line: 1,
         },
       ],
     },