feat: Add rule to recommended Vitest ESLint config (#827)

y-hsgw · web-flow · commit bc95b107e78f · 2025-11-24T16:08:49.000-06:00
* feat: add recommended rules for testing best practices

* docs: update docs
diff --git a/README.md b/README.md
diff --git a/docs/rules/no-conditional-expect.md b/docs/rules/no-conditional-expect.md
@@ -1,6 +1,6 @@
 # Disallow conditional expects (`vitest/no-conditional-expect`)
 
-⚠️ This rule _warns_ in the 🌐 `all` config.
+💼⚠️ This rule is enabled in the ✅ `recommended` config. This rule _warns_ in the 🌐 `all` config.
 
 <!-- end auto-generated rule header -->
 
diff --git a/docs/rules/no-disabled-tests.md b/docs/rules/no-disabled-tests.md
@@ -1,6 +1,6 @@
 # Disallow disabled tests (`vitest/no-disabled-tests`)
 
-⚠️ This rule _warns_ in the 🌐 `all` config.
+⚠️ This rule _warns_ in the following configs: 🌐 `all`, ✅ `recommended`.
 
 <!-- end auto-generated rule header -->
 
diff --git a/docs/rules/no-focused-tests.md b/docs/rules/no-focused-tests.md
@@ -1,6 +1,6 @@
 # Disallow focused tests (`vitest/no-focused-tests`)
 
-⚠️ This rule _warns_ in the 🌐 `all` config.
+💼⚠️ This rule is enabled in the ✅ `recommended` config. This rule _warns_ in the 🌐 `all` config.
 
 🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
 
diff --git a/docs/rules/no-interpolation-in-snapshots.md b/docs/rules/no-interpolation-in-snapshots.md
@@ -1,6 +1,6 @@
 # Disallow string interpolation in snapshots (`vitest/no-interpolation-in-snapshots`)
 
-⚠️ This rule _warns_ in the 🌐 `all` config.
+💼⚠️ This rule is enabled in the ✅ `recommended` config. This rule _warns_ in the 🌐 `all` config.
 
 🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
 
diff --git a/docs/rules/no-mocks-import.md b/docs/rules/no-mocks-import.md
@@ -1,6 +1,6 @@
 # Disallow importing from **mocks** directory (`vitest/no-mocks-import`)
 
-⚠️ This rule _warns_ in the 🌐 `all` config.
+💼⚠️ This rule is enabled in the ✅ `recommended` config. This rule _warns_ in the 🌐 `all` config.
 
 <!-- end auto-generated rule header -->
 
diff --git a/docs/rules/no-standalone-expect.md b/docs/rules/no-standalone-expect.md
@@ -1,6 +1,6 @@
 # Disallow using `expect` outside of `it` or `test` blocks (`vitest/no-standalone-expect`)
 
-⚠️ This rule _warns_ in the 🌐 `all` config.
+💼⚠️ This rule is enabled in the ✅ `recommended` config. This rule _warns_ in the 🌐 `all` config.
 
 <!-- end auto-generated rule header -->
 
diff --git a/docs/rules/valid-expect-in-promise.md b/docs/rules/valid-expect-in-promise.md
@@ -1,6 +1,6 @@
 # Require promises that have expectations in their chain to be valid (`vitest/valid-expect-in-promise`)
 
-⚠️ This rule _warns_ in the 🌐 `all` config.
+💼⚠️ This rule is enabled in the ✅ `recommended` config. This rule _warns_ in the 🌐 `all` config.
 
 <!-- end auto-generated rule header -->
 
diff --git a/src/index.ts b/src/index.ts
@@ -103,13 +103,20 @@ const allRules = {
 
 const recommendedRules = {
   'expect-expect': 'error',
+  'no-conditional-expect': 'error',
+  'no-disabled-tests': 'warn',
+  'no-focused-tests': 'error',
   'no-commented-out-tests': 'error',
   'no-identical-title': 'error',
   'no-import-node-test': 'error',
+  'no-interpolation-in-snapshots': 'error',
+  'no-mocks-import': 'error',
+  'no-standalone-expect': 'error',
   'prefer-called-exactly-once-with': 'error',
   'require-local-test-context-for-concurrent-snapshots': 'error',
   'valid-describe-callback': 'error',
   'valid-expect': 'error',
+  'valid-expect-in-promise': 'error',
   'valid-title': 'error',
 } as const satisfies RuleList
 
