Removing Benchmark Config & Engine #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lucaro
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
I think it makes sense to remove this, as it is not really consistent with the project structure anymore. We probably want an internal mechanism to measure things, both for benchmarking as well as for analytics in production. The whole prometheus logic would probably be a good start point for this.
silvanheller
added a commit
that referenced
this pull request
Jun 10, 2022
Former-commit-id: 7078dac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94 by removing the benchmarking engine. I'm removing it because: