Skip to content

[V1] EngineCore supports profiling #10564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 23, 2024
Merged

[V1] EngineCore supports profiling #10564

merged 4 commits into from
Nov 23, 2024

Conversation

Abatom
Copy link
Contributor

@Abatom Abatom commented Nov 22, 2024 •
edited by github-actions bot
Loading

EngineCore supports profiling, inspired by V0.

The idle time of the GPU has significantly decreased.

image

@Abatom
add profiler
2aa3a4a 
Signed-off-by: Abatom <abzhonghua@gmail.com>
@Abatom
Merge branch 'main' into v1-profiler
a90f291
@Abatom
fix bug
667e194 
Signed-off-by: Abatom <abzhonghua@gmail.com>
@Abatom
format
20d5ece 
Signed-off-by: Abatom <abzhonghua@gmail.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 22, 2024
@Abatom Abatom requested a review from comaniac November 23, 2024 01:12
@comaniac comaniac merged commit d345f40 into vllm-project:main Nov 23, 2024
59 of 61 checks passed
@jikunshang jikunshang mentioned this pull request Nov 26, 2024
Merged
@ywang96 ywang96 mentioned this pull request Dec 12, 2024
Merged
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@Abatom
[V1] EngineCore supports profiling (vllm-project#10564)
0a1bc43 
Signed-off-by: Abatom <abzhonghua@gmail.com>
anko-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request Feb 12, 2025
@Abatom @anko-intel
[V1] EngineCore supports profiling (vllm-project#10564)
0791bf1 
Signed-off-by: Abatom <abzhonghua@gmail.com>
@Abatom Abatom deleted the v1-profiler branch June 25, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abatom @comaniac