[Core] v1: Use atexit to handle engine core client shutdown #11076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing V1 + multiprocessing, I observed that my offline inference test script would hang at the end and not exit. There was shutdown code here that depended on garbage collection to trigger it, but it wouldn't get far enough for that to happen. This approach of using `atexit` to register the cleanup handler is the same as is used in the `multiproc_executor`. Signed-off-by: Russell Bryant <rbryant@redhat.com>
russellb
requested review from
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
robertgshaw2-redhat
approved these changes
Dec 11, 2024
github-actions
bot
added
the
ready
tlrmchlsmth
approved these changes
Dec 11, 2024
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
…ject#11076) Signed-off-by: Russell Bryant <rbryant@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing V1 + multiprocessing, I observed that my offline
inference test script would hang at the end and not exit. There was
shutdown code here that depended on garbage collection to trigger it,
but it wouldn't get far enough for that to happen.
This approach of using
atexitto register the cleanup handler is thesame as is used in the
multiproc_executor.Signed-off-by: Russell Bryant rbryant@redhat.com