Skip to content

Conversation

tlrmchlsmth
Copy link
Member

@tlrmchlsmth tlrmchlsmth commented Dec 16, 2024

It's nicer this way, since we no longer need to unregister shutdown from atexit

Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 17, 2024 03:57
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 17, 2024
@youkaichao youkaichao disabled auto-merge December 17, 2024 06:11
@youkaichao youkaichao merged commit 2bfdbf2 into vllm-project:main Dec 17, 2024
59 of 64 checks passed
@youkaichao youkaichao deleted the weakref_finalize branch December 17, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants