Skip to content

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Dec 19, 2024

Molmo is a special case where the input processing also handles the preprocessing of multimodal data, therefore the dummy data for this model is defined as MultiModalKwags without a PIL.Image.

This PR adds a temporary workaround to fix this issue as well as renaming some functions to indicate their purposes better.

ywang96 added 2 commits December 19, 2024 08:32
Signed-off-by: ywang96 <ywang@example.com>
fix
Signed-off-by: ywang96 <ywang@example.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 19, 2024 09:21
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 19, 2024
@ywang96 ywang96 disabled auto-merge December 19, 2024 11:07
Signed-off-by: ywang96 <ywang@example.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 19, 2024 15:01
@DarkLight1337 DarkLight1337 merged commit 7379b3d into vllm-project:main Dec 19, 2024
53 checks passed
mzusman pushed a commit to mzusman/vllm that referenced this pull request Mar 12, 2025
Signed-off-by: ywang96 <ywang@example.com>
Co-authored-by: ywang96 <ywang@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants