Skip to content

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Sep 12, 2025

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Isotr0py and others added 5 commits September 10, 2025 15:51
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@Isotr0py Isotr0py requested a review from ywang96 September 12, 2025 04:52
@mergify mergify bot added the performance Performance-related issues label Sep 12, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the MMVU video dataset for benchmarking and removes the deprecated benchmark_dataset.py file. The changes are well-structured, but I've identified an issue in the new MMVUDataset implementation where the sample method is missing the no_oversample parameter. This would cause the --no-oversample CLI flag to be ignored for this dataset. I've provided a code suggestion to fix this inconsistency.

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@DarkLight1337
Copy link
Member

Can you post the result of benchmarking some models on this dataset?

@tjtanaa
Copy link
Contributor

tjtanaa commented Sep 12, 2025

@Isotr0py amazing feature. Thank you for this PR. Need this.

@david6666666
Copy link
Contributor

david6666666 commented Sep 15, 2025

Nice one, We really need a video benchmark dataset.

Copy link

mergify bot commented Sep 16, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @Isotr0py.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 16, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@Isotr0py
Copy link
Member Author

Can you post the result of benchmarking some models on this dataset?

Test suite: T4 GPU x 2

vllm serve Qwen/Qwen2-VL-2B-Instruct -tp 2 --max-model-len 32768 --enforce-eager --max-num-seqs 5

Benchmark commands:

vllm bench serve \
  --backend openai-chat \
  --endpoint-type openai-chat \
  --model Qwen/Qwen2-VL-2B-Instruct \
  --endpoint /v1/chat/completions \
  --dataset-name hf \
  --dataset-path yale-nlp/MMVU \
  --hf-split validation \
  --num-prompts 10

Results:

Initial test run completed. Starting main benchmark run...
Traffic request rate: inf
Burstiness factor: 1.0 (Poisson process)
Maximum request concurrency: None
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 10/10 [02:10<00:00, 13.00s/it]
============ Serving Benchmark Result ============
Successful requests:                     10        
Benchmark duration (s):                  130.04    
Total input tokens:                      578       
Total generated tokens:                  605       
Request throughput (req/s):              0.08      
Output token throughput (tok/s):         4.65      
Total Token throughput (tok/s):          9.10      
---------------Time to First Token----------------
Mean TTFT (ms):                          64757.39  
Median TTFT (ms):                        58903.87  
P99 TTFT (ms):                           112885.96 
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          837.82    
Median TPOT (ms):                        771.18    
P99 TPOT (ms):                           1754.11   
---------------Inter-token Latency----------------
Mean ITL (ms):                           632.08    
Median ITL (ms):                         316.43    
P99 ITL (ms):                            3830.31   
==================================================

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@Isotr0py Isotr0py requested a review from hmellor as a code owner September 16, 2025 14:45
@mergify mergify bot added documentation Improvements or additions to documentation and removed needs-rebase labels Sep 16, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 16, 2025 15:20
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 16, 2025
@DarkLight1337 DarkLight1337 merged commit 5a411ef into vllm-project:main Sep 17, 2025
46 of 54 checks passed
@Isotr0py Isotr0py deleted the mmvu-benchmark branch September 17, 2025 03:39
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
…atasets (vllm-project#24719)

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
…atasets (vllm-project#24719)

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: charlifu <charlifu@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants