-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Benchmarks] Add MMVU video dataset support and clean up deprecated datasets #24719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the MMVU video dataset for benchmarking and removes the deprecated benchmark_dataset.py
file. The changes are well-structured, but I've identified an issue in the new MMVUDataset
implementation where the sample
method is missing the no_oversample
parameter. This would cause the --no-oversample
CLI flag to be ignored for this dataset. I've provided a code suggestion to fix this inconsistency.
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Can you post the result of benchmarking some models on this dataset? |
@Isotr0py amazing feature. Thank you for this PR. Need this. |
Nice one, We really need a video benchmark dataset. |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Test suite: T4 GPU x 2
Benchmark commands:
Results:
|
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…atasets (vllm-project#24719) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…atasets (vllm-project#24719) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: charlifu <charlifu@amd.com>
Purpose
benchmarks/benchmark_dataset.py
asbenchmarks/benchmark_serving.py
etc have been deprecated byvllm bench
.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.