Skip to content

Conversation

bigPYJ1151
Copy link
Member

@bigPYJ1151 bigPYJ1151 commented Sep 12, 2025

Purpose

Test Plan

CI tests

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: jiang1.li <jiang1.li@intel.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a temporary measure to skip tests for prompt embeddings on the V1-only CPU backend. The rationale is that prompt embeddings currently fall back to the V0 backend, which is deprecated on CPU. The change correctly uses pytest.skip to bypass these specific test configurations, and a helpful comment points to the future pull request that will resolve the underlying issue. The implementation is sound and serves as a good interim solution to maintain CI stability.

@bigPYJ1151 bigPYJ1151 changed the title [CI/Build] Skip prompt embeddings on V1-only CPU backend [CI/Build] Skip prompt embeddings tests on V1-only CPU backend Sep 12, 2025
@jikunshang jikunshang added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 12, 2025
@bigPYJ1151 bigPYJ1151 merged commit 59d5d2c into vllm-project:main Sep 12, 2025
34 checks passed
@bigPYJ1151 bigPYJ1151 deleted the fix_cpu_gen branch September 12, 2025 10:51
@qthequartermasterman
Copy link
Contributor

Thank you for catching this!

skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
dsxsteven pushed a commit to dsxsteven/vllm_splitPR that referenced this pull request Sep 15, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants