[Bugfix] Fix GPUModelRunner has no attribute lora_manager #24762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeejeelee
requested review from
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an AttributeError when LoRA is not enabled by introducing a centralized check _ensure_lora_enabled. This improves error handling by raising a more informative RuntimeError. While this is applied to most LoRA-related methods, the check is missing in list_loras, which would reintroduce the original bug. My review includes a critical comment to address this omission.
jeejeelee
force-pushed
the
fix-lora-exception
branch
from
4bb5d14 to
15d6661
Compare
DarkLight1337
approved these changes
Sep 12, 2025
github-actions
bot
added
the
ready
|
@DarkLight1337 This pre-commit failure looks unrelated |
dsxsteven
pushed a commit
to dsxsteven/vllm_splitPR
that referenced
this pull request
Sep 15, 2025
…ct#24762) Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Sep 15, 2025
…ct#24762) Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: bbartels <benjamin@bartels.dev>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…ct#24762) Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
FIX #24672
When
--enable-lorais missing (like #24672), it should raise the following exception instead of theAttributeError: 'GPUModelRunner' object has no attribute 'lora_manager'that ike #24672 encountered.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.