[Misc] Correct an outdated comment. #24765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After initially adding "auto" mode for structured output, we quickly changed our minds that we wanted "auto" to be the default behavior. Fix this comment that is no longer true. Signed-off-by: Russell Bryant <rbryant@redhat.com>
russellb
requested review from
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates an outdated comment in vllm/v1/engine/processor.py. The change aligns the code's documentation with its behavior, where 'auto' is the default for the structured output backend. This improves code clarity and maintainability. The change is accurate and I have no further suggestions.
DarkLight1337
approved these changes
Sep 13, 2025
dsxsteven
pushed a commit
to dsxsteven/vllm_splitPR
that referenced
this pull request
Sep 15, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Sep 15, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: bbartels <benjamin@bartels.dev>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After initially adding "auto" mode for structured output, we quickly
changed our minds that we wanted "auto" to be the default behavior.
Fix this comment that is no longer true.
Signed-off-by: Russell Bryant rbryant@redhat.com