-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Bugfix] Update import path for bc_linter_include #24766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mohammad Miadh Angkad <mangkad.bsdsba2027@aim.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses an ImportError
by changing the import path for bc_linter_include
. The modification from a top-level import to a direct import from vllm._bc_linter
is a correct and robust fix. This change not only resolves the immediate error but also improves code structure by making the dependency explicit and avoiding potential circular import issues that can arise from fragile top-level imports. The change is well-contained and appropriate.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
Hi @mmangkad , may I ask why you close this PR? It can basically fix the issue that throws import error if a vLLM is not executed inside the vLLM directory. |
Hi @yaochengji, I mistakenly thought that this wasn't necessary anymore. Reopening this for review and approval. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
Signed-off-by: Mohammad Miadh Angkad <mangkad.bsdsba2027@aim.edu>
Signed-off-by: Mohammad Miadh Angkad <mangkad.bsdsba2027@aim.edu>
Signed-off-by: Mohammad Miadh Angkad <mangkad.bsdsba2027@aim.edu> Signed-off-by: charlifu <charlifu@amd.com>
Purpose
Resolves an
ImportError
that occurs when loading certain models due to a fragile top-level import within the model inspection subprocess. The exact error is:This PR fixes the issue by updating the import path in
vllm/v1/core/sched/output.py
to be more direct and robust.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.