[Benchmarks] Throw usage error when using dataset-name random and dataset-path together #24819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There's some confusion #24684 that default behavior for
vllm bench serve
is incorrect. This is due tovllm bench serve
uses random by default and it does not throw any errors when using provide a shardgpt dataset path lol.Test Plan
Test Result
all throw the following error:
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.