Skip to content

Conversation

yeqcharlotte
Copy link
Collaborator

@yeqcharlotte yeqcharlotte commented Sep 14, 2025

Purpose

There's some confusion #24684 that default behavior for vllm bench serve is incorrect. This is due to vllm bench serve uses random by default and it does not throw any errors when using provide a shardgpt dataset path lol.

Test Plan

# only specify dataset path
vllm bench serve --model meta-llama/Llama-3.1-8B-Instruct --percentile-metrics ttft,tpot,itl,e2el --dataset-path /models/ShareGPT_Vicuna_unfiltered/ShareGPT_V3_unfiltered_cleaned_split.json --max-concurrency 64 --num-prompts 640 --ignore-eos --sharegpt-output-len 512
# specify dataset path first, then dataset name
vllm bench serve --model meta-llama/Llama-3.1-8B-Instruct --percentile-metrics ttft,tpot,itl,e2el --dataset-path /models/ShareGPT_Vicuna_unfiltered/ShareGPT_V3_unfiltered_cleaned_split.json --dataset-name random --max-concurrency 64 --num-prompts 640 --ignore-eos --sharegpt-output-len 512
# specify dataset name first, then dataset path
vllm bench serve --model meta-llama/Llama-3.1-8B-Instruct --dataset-name random --percentile-metrics ttft,tpot,itl,e2el --dataset-path /models/ShareGPT_Vicuna_unfiltered/ShareGPT_V3_unfiltered_cleaned_split.json --max-concurrency 64 --num-prompts 640 --ignore-eos --sharegpt-output-len 512

Test Result

all throw the following error:

usage: vllm bench serve [options]
vllm bench <bench_type> [options] serve: error: Cannot use 'random' dataset with --dataset-path. Please specify the appropriate --dataset-name (e.g., 'sharegpt', 'custom', 'sonnet') for your dataset file: /models/ShareGPT_Vicuna_unfiltered/ShareGPT_V3_unfiltered_cleaned_split.json

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
@yeqcharlotte yeqcharlotte marked this pull request as ready for review September 14, 2025 05:58
@mergify mergify bot added the performance Performance-related issues label Sep 14, 2025
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

dataset_path = getattr(namespace, 'dataset_path', None)

# Validate the combination
if dataset_name == "random" and dataset_path is not None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: also dataset_path is not empty string, like ""?

@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 14, 2025
@houseroad houseroad enabled auto-merge (squash) September 14, 2025 16:19
@houseroad houseroad merged commit ff68035 into vllm-project:main Sep 14, 2025
58 checks passed
dsxsteven pushed a commit to dsxsteven/vllm_splitPR that referenced this pull request Sep 15, 2025
…aset-path together (vllm-project#24819)

Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
bbartels pushed a commit to bbartels/vllm that referenced this pull request Sep 15, 2025
…aset-path together (vllm-project#24819)

Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
Signed-off-by: bbartels <benjamin@bartels.dev>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
…aset-path together (vllm-project#24819)

Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants