Move SpeculativeConfig from config/__init__.py to config/speculative.py
#24904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive.py` Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
sighingnow,
heheda12345,
benchislett,
luccafong,
simon-mo,
WoosukKwon,
youkaichao,
robertgshaw2-redhat,
mgoin,
tlrmchlsmth,
houseroad,
yewentao256 and
ProExpertProg
as code owners
mergify
bot
added
performance
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase by moving SpeculativeConfig into its own file, vllm/config/speculative.py, from the large vllm/config/__init__.py. This is a good step towards better code organization.
The changes in existing files are mostly updating the import paths for SpeculativeConfig, which are all correct.
However, the new file vllm/config/speculative.py introduces a circular dependency by importing ModelConfig from vllm.config, while vllm.config also imports from vllm.config.speculative. I've left a comment with a suggestion on how to resolve this using forward references and local imports, which is a common pattern to break such cycles.
mgoin
reviewed
Sep 15, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
DarkLight1337
added
the
ready
DarkLight1337
approved these changes
Sep 16, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…tive.py` (vllm-project#24904) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18953