Skip to content

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Sep 15, 2025

Remove V0 encoder decoder model runner.
Also, this PR deletes the deprecated models such as BART. After this PR, Whisper will be the only encoder-decoder model that are supported by vLLM.

@mergify mergify bot added documentation Improvements or additions to documentation llama Related to Llama models multi-modality Related to multi-modality (#4194) new-model Requests to new models v1 labels Sep 15, 2025
@WoosukKwon WoosukKwon changed the base branch from main to codex/remove-v0-encoder-decoder-model-support September 15, 2025 19:51
Copy link

mergify bot commented Sep 15, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @WoosukKwon.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restores support for Mllama4 and Skywork models. As part of this, it also removes a significant amount of code and tests related to a generic encoder-decoder model runner, effectively dropping support for models like BART, mBART, Donut, Florence2, and the original Mllama. While the changes are extensive, they appear to be mostly consistent with this goal. However, I've identified two critical bugs in an example script that will lead to NameError exceptions at runtime due to variables being used after their definitions were removed.

@WoosukKwon WoosukKwon changed the base branch from codex/remove-v0-encoder-decoder-model-support to main September 15, 2025 19:53
@mergify mergify bot removed the needs-rebase label Sep 15, 2025
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
@WoosukKwon WoosukKwon force-pushed the codex/remove-v0-encoder-decoder-model-support-htgyni branch from 848b568 to c66902d Compare September 15, 2025 20:04
@WoosukKwon WoosukKwon changed the title Restore Mllama4 and Skywork models Remove V0 Encoder-Decoder Support Sep 15, 2025
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 15, 2025
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
@mergify mergify bot added the ci/build label Sep 15, 2025
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
@WoosukKwon WoosukKwon merged commit 759ef49 into main Sep 16, 2025
82 checks passed
@WoosukKwon WoosukKwon deleted the codex/remove-v0-encoder-decoder-model-support-htgyni branch September 16, 2025 04:17
@mfournioux
Copy link
Contributor

@WoosukKwon your PR is deleting Donut model from offline inference examples. Could you please let me know why Donut model is not longer supported while this PR has been merged recently #23229 ?

@WoosukKwon
Copy link
Collaborator Author

@mfournioux We were planning to discontinue encoder-decoder model support (except Whisper) in the course of V0 deprecation. I think the PR was merged without the lack of this information.

FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
@mfournioux
Copy link
Contributor

mfournioux commented Sep 25, 2025

@mfournioux We were planning to discontinue encoder-decoder model support (except Whisper) in the course of V0 deprecation. I think the PR was merged without the lack of this information.

Many thanks for your reply, why only Whisper model is kept and others like Donut are not longer supported regarding this PR ? It means Donut model is not longer supported for next vllm version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build codex documentation Improvements or additions to documentation llama Related to Llama models multi-modality Related to multi-modality (#4194) new-model Requests to new models ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants