Skip to content

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Sep 18, 2025

Purpose

Test Plan

pytest -s -v tests/models/multimodal/generation/test_common.py -k qwen3_vl

Test Result

Test should pass


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@mergify mergify bot added multi-modality Related to multi-modality (#4194) qwen Related to Qwen models labels Sep 18, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@Isotr0py Isotr0py marked this pull request as ready for review September 19, 2025 06:22
@DarkLight1337
Copy link
Member

Should we wait until model release before actually merging this?

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@Isotr0py
Copy link
Member Author

Should we wait until model release before actually merging this?

I'm fine to wait until model release and Transformers upgrade, because this test won't run on CI without them.

The goal of PR is just to provide a test for generation correctness validation, so that we can run correctness test for other Qwen3-VL related PRs locally to avoid regression. So whether merge this PR or not won't be a big deal IMO.

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-modality Related to multi-modality (#4194) qwen Related to Qwen models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants