[KV offload][1b/N] rename offloading to kv_offload #25191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames v1/offloading to v1/kv_offload to avoid confusion with weights offloading. Signed-off-by: Or Ozeri <oro@il.ibm.com>
orozery
requested review from
ApostaC,
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly renames the v1/offloading module and its references to v1/kv_offload. The changes are consistent across the modified files. However, the refactoring appears incomplete. To fully align with the goal of avoiding confusion with weights offloading, it would be beneficial to also rename classes, functions, and documentation within the newly named module. For example, OffloadingWorker could become KVOffloadWorker, and the test function test_offloading_worker could be renamed to test_kv_offload_worker. While this might be planned for a subsequent PR in this series, completing the renaming would significantly improve code clarity and maintainability.
njhill
approved these changes
Sep 18, 2025
ywang96
pushed a commit
to ywang96/vllm
that referenced
this pull request
Sep 19, 2025
Signed-off-by: Or Ozeri <oro@il.ibm.com>
debroy-rh
pushed a commit
to debroy-rh/vllm
that referenced
this pull request
Sep 19, 2025
Signed-off-by: Or Ozeri <oro@il.ibm.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Or Ozeri <oro@il.ibm.com>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Or Ozeri <oro@il.ibm.com> Signed-off-by: charlifu <charlifu@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames v1/offloading to v1/kv_offload to avoid confusion with weights offloading.