-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Qwen] Remove cuda hard-code in qwen3 next #25243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…latform-independent device selectors Signed-off-by: Icey <1790571317@qq.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the device specification in the Qwen3-Next model to be platform-independent. The change replaces a hard-coded CUDA device reference (torch.cuda.current_device()
) with a platform-agnostic device selector (current_platform.current_device()
). This is a good improvement for code portability across different hardware backends like CUDA, ROCm, and others supported by vLLM. The implementation is correct and follows the established pattern for platform abstraction in the codebase. I have no further comments.
LGTM, this make it easier for oot platforms to support Qwen3 Next, thx! |
Signed-off-by: Icey <1790571317@qq.com>
Signed-off-by: Icey <1790571317@qq.com>
Signed-off-by: Icey <1790571317@qq.com> Signed-off-by: charlifu <charlifu@amd.com>
Purpose
[Qwen] Changed device specification from hard-coded CUDA devices to platform-independent device selectors
Test Plan
Test through the exsiting tests
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.