allow disable flashinfer prefill #25276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luccafong
requested review from
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
|
@luccafong has exported this pull request. If you are a Meta employee, you can view the originating diff in D81994905. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new environment variable, VLLM_DISABLE_FLASHINFER_PREFILL, to provide an option to disable FlashInfer prefill. This change addresses a compatibility issue on GB200 with CutlassMLA FP8. The implementation adds the new flag in vllm/envs.py and correctly uses it in vllm/v1/attention/backends/mla/common.py to control the feature. The default behavior is unchanged. The changes are correct and well-contained.
Summary: GB200 FlashInfer Prefill is not compatible with CutlassMLA FP8, allowing disable it for now.
Differential Revision: D81994905
Signed-off-by: Lu Fang <fanglu@fb.com>
luccafong
force-pushed
the
export-D81994905
branch
from
cc162ce to
95df807
Compare
mgoin
approved these changes
Sep 19, 2025
|
Seems reasonable for now, thanks |
github-actions
bot
added
the
ready
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Lu Fang <fanglu@fb.com>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Lu Fang <fanglu@fb.com> Signed-off-by: charlifu <charlifu@amd.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Lu Fang <fanglu@fb.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: GB200 FlashInfer Prefill is not compatible with CutlassMLA FP8, allowing disable it for now.
Differential Revision: D81994905