Remove redundant mutates_args and dispatch_key for direct_register_custom_op #25512
+9
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stom_op Signed-off-by: mgoin <mgoin64@gmail.com>
mgoin
requested review from
gshtras,
sighingnow,
zou3519,
youkaichao,
ProExpertProg,
jeejeelee,
tdoublep,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
LucasWilkinson
as code owners
mergify
bot
added
deepseek
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the direct_register_custom_op function by making the mutates_args and dispatch_key parameters optional. This change simplifies the function's call sites by removing redundant default arguments, leading to cleaner and more maintainable code. The modifications are applied consistently across numerous files. The overall change is a good improvement, and I have no further comments.
yewentao256
approved these changes
Sep 23, 2025
5 tasks
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…stom_op (vllm-project#25512) Signed-off-by: mgoin <mgoin64@gmail.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
…stom_op (#25512) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.