Skip to content

Conversation

nicole-lihui
Copy link
Contributor

@nicole-lihui nicole-lihui commented Sep 24, 2025

Purpose

eliminate duplicate split_enc_dec_inputs calls

This improves performance by
reducing redundant function calls while maintaining the same validation logic.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@nicole-lihui nicole-lihui changed the title eliminate duplicate split_enc_dec_inputs calls optimize: eliminate duplicate split_enc_dec_inputs calls Sep 24, 2025
@mergify mergify bot added the v1 label Sep 24, 2025
Copy link

mergify bot commented Sep 24, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @nicole-lihui.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 24, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the code to eliminate duplicate calls to split_enc_dec_inputs in llm_engine.py and processor.py. By calling split_enc_dec_inputs once and passing the results to _validate_model_inputs, the change improves performance by reducing redundant work. The implementation is correct and maintains the existing validation logic. I have reviewed the changes and found no issues.

@nicole-lihui nicole-lihui force-pushed the optimize/eliminate-duplicate-split-enc-dec-calls branch from 86ef49f to 30548d4 Compare September 24, 2025 10:59
@mergify mergify bot removed the needs-rebase label Sep 24, 2025
Signed-off-by: nicole-lihui <nicole.li@daocloud.io>
@nicole-lihui nicole-lihui force-pushed the optimize/eliminate-duplicate-split-enc-dec-calls branch from 30548d4 to 723d780 Compare September 24, 2025 11:44
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 25, 2025 03:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 25, 2025
@DarkLight1337 DarkLight1337 merged commit c85be1f into vllm-project:main Sep 25, 2025
45 of 51 checks passed
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: nicole-lihui <nicole.li@daocloud.io>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants