[Misc] Simplify PoolerOutput and move to v1/outputs
#25629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
DarkLight1337
requested review from
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac,
alexm-redhat,
zhuohan123,
youkaichao and
22quinn
as code owners
DarkLight1337
changed the title
v1/outputsv1/outputs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the PoolerOutput by removing the msgspec wrappers and simplifying its definition to a type alias for Union[torch.Tensor, list[torch.Tensor]]. The definition has been moved from vllm/sequence.py to vllm/v1/outputs.py. The changes are consistently applied across the codebase, including updates to pooler implementations and their usage in the model runner. This simplification makes the code more direct and easier to understand. The refactoring appears correct and well-executed, with no apparent issues.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
commented
Sep 25, 2025
| hidden_states=hidden_states, | ||
| pooling_metadata=pooling_metadata, | ||
| ) | ||
| raw_pooler_output = json_map_leaves( |
There was a problem hiding this comment.
I think it makes more sense for model runner to handle device transfer
2 tasks
Zhuul
pushed a commit
to Zhuul/vllm
that referenced
this pull request
Sep 26, 2025
…5629) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The removal of V0 lets us get rid of the
msgspecwrappers and access the data in a more direct manner.cc @maxdebayser @noooop
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.