[mypy] Fix wrong type annotations related to tuple #25660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
DarkLight1337
requested review from
ywang96,
mgoin,
tlrmchlsmth,
WoosukKwon and
yewentao256
as code owners
mergify
bot
added
multi-modality
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on correcting tuple type annotations throughout the codebase to improve mypy checking, for instance by changing tuple[int] to tuple[int, ...] for variable-length integer tuples. The changes are generally sound and improve type correctness. I've identified a couple of instances where the updated type hints are still not quite right and have provided suggestions for correction.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
hmellor
approved these changes
Sep 25, 2025
Zhuul
pushed a commit
to Zhuul/vllm
that referenced
this pull request
Sep 26, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
More fixes for the type checker
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.