-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Model] Supplement to PR 24862: Pass param prefix to LLMHead #25805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to pass the prefix
parameter to ParallelLMHead
instances across various models, which is a crucial step for ensuring correct quantization. While the intent is correct, the implementation introduces inconsistencies in several models where the provided prefix does not match the module's attribute name. This could lead to problems with quantization configurations that rely on accurate module paths. Furthermore, in models that utilize a ModuleList
for multiple LM heads, the same prefix is incorrectly applied to all heads, which would prevent them from being quantized differently if needed. I've added specific comments and suggestions to address these inconsistencies.
92c39e0
to
d18f880
Compare
This pull request has merge conflicts that must be resolved before it can be |
6bddb18
to
5163bb6
Compare
Signed-off-by: whx-sjtu <2952154980@qq.com>
Head branch was pushed to by a user without write access
0b7827b
to
655cb6a
Compare
Signed-off-by: whx-sjtu <2952154980@qq.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
…oject#25805) Signed-off-by: whx-sjtu <2952154980@qq.com>
Purpose
This PR is a supplement to PR #24862, passing some prefix parameters that were previously missed in that PR to LLMHead
Test Plan
No extra test needed.
Test Result
All current ci tests should pass.
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.