[V0 Deprecation] Remove vllm.worker and update according imports
#25901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
aarnphm
requested review from
hmellor,
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac,
alexm-redhat,
zhuohan123,
youkaichao and
22quinn
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively removes the deprecated vllm.worker directory and migrates its functionality to vllm.v1, successfully deprecating the V0 worker implementation. The changes are clean and well-executed. Key improvements include:
- Consolidating worker base classes into
vllm/v1/worker/worker_base.py. - Removing the insecure and deprecated usage of
cloudpicklefor dynamic worker class loading, replacing it with a clear error for unsupported configurations. - Simplifying the worker selection logic in platform-specific files (
cuda.py,rocm.py) to always use the V1 worker. - Updating all relevant imports across the codebase to point to the new
vllm.v1.workerpath.
The refactoring makes the codebase cleaner, more secure, and easier to maintain by removing the old V0 logic. I have reviewed the changes and found no issues. The implementation is solid.
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
zhuohan123
approved these changes
Sep 29, 2025
njhill
reviewed
Sep 29, 2025
|
Will wait to trigger CI to make sure there aren't any failures |
WoosukKwon
reviewed
Sep 29, 2025
Comment on lines
+115
to
+119
| def execute_model( | ||
| self, | ||
| execute_model_req: Optional[ExecuteModelRequest] = None | ||
| ) -> Optional[list[SamplerOutput]]: | ||
| raise NotImplementedError |
There was a problem hiding this comment.
FYI, this method is also outdated. V1 doesn't use ExecuteModelRequest at all.
pdasigi
pushed a commit
to pdasigi/vllm
that referenced
this pull request
Oct 2, 2025
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
…25901) Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
vllm/workerdirectory and migrate relevant class tovllm/v1Some change behaviours include:
init_worker(cc @russellb)I haven't touched the ray executor part yet.
Signed-off-by: Aaron Pham contact@aarnphm.xyz