Skip to content

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Oct 4, 2025

Purpose

This helps simplify the implementation of HyperCLOVAX-SEED-Vision and enable merge_by_field_config=True for that model.

Other changes:

cc @bbeckca

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 4, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for nested tensor structures within TensorSchema, a significant enhancement for managing complex multimodal inputs. The refactoring in hyperclovax_vision.py to adopt this new schema notably improves code clarity and maintainability. I have identified two critical issues in the _call_hf_processor method where video input data structures are incorrectly constructed, which would result in runtime errors. My review provides specific suggestions to rectify these problems. The other modifications, including the core logic updates in tensor_schema.py and the corresponding test adjustments, appear to be well-implemented.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for nested structures in TensorSchema, which simplifies the implementation for models like HyperCLOVAX-SEED-Vision. The changes include refactoring hyperclovax_vision.py to use the new TensorSchema capabilities, renaming a field in Phi3VImagePixelInputs for clarity, and fixing a minor bug in glm4_1v.py. The refactoring in hyperclovax_vision.py is substantial and improves code clarity and maintainability. I have one suggestion to further improve the maintainability of the parsing logic for multimodal inputs.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vllm-bot vllm-bot merged commit 44ea851 into vllm-project:main Oct 4, 2025
51 of 53 checks passed
@DarkLight1337 DarkLight1337 deleted the tensor-schema-nested branch October 4, 2025 08:20
@bbeckca
Copy link
Contributor

bbeckca commented Oct 4, 2025

Looks good. Thanks for improving @DarkLight1337!

tomeras91 pushed a commit to tomeras91/vllm that referenced this pull request Oct 6, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants