Update requirements-dev.txt to include package for benchmarking scripts. #3181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To add aiohttp, which is required for benchmarking scripts.
WoosukKwon
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Hi @wangchen615, thanks for the PR! I have a quick question: Why is the version fixed? Can we just simply use aiohttp without a specific version?
requirements-dev.txt
Outdated
| ray | ||
|
|
||
| # Benchmarking | ||
| aiohttp==3.9.3 |
There was a problem hiding this comment.
Why is the version fixed? Can we just simply use aiohttp without a specific version?
There was a problem hiding this comment.
I think using aiohttp without a specific version should be okay since we don't use anything special other than the ClientSession and ClientTimeout which shouldn't have breaking changes very often.
zhuohan123
approved these changes
Mar 7, 2024
dtransposed
pushed a commit
to afeldman-nm/vllm
that referenced
this pull request
Mar 26, 2024
…ts. (vllm-project#3181) Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add aiohttp==3.9.3, which is required for benchmarking scripts.