Bugfixes and reactors for install-vrcx.sh #856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for doing this in a single commit but we're past the point to fix this now.
This PR fixes #841 by switching to using the
wine
binary and instead asking perWINEARCH
to use 64bit, which should be more consistent across distros.This PR also fixes #853 which describes two separate issues:
WINEDLLOVERRIDES
as described in this Wine bug report as workaround for a blackscreen issue.I've took the opportunity to also clean up some stuff, the script now:
$HOME
consistently instead of switching between~
and$HOME
$XDG_DATA_HOME
, which signals that the user has an alternative preferred path for what otherwise defaults to$HOME/.local/share
$WINEPREFIX
consistently$HOME/.local/bin
, so we just have to use it as-is.ln -nsf
to override the symbolic link we do to install the vrcx binary wrapper script into$HOME/.local/bin
.set -u
to bail on unset variables, which adds guard rails for when this script inevitably tripsWine automatically creates
$XDG_DATA_HOME/applications
and$XDG_DATA_HOME/icons
if it doesn't exist to populate it with its own files, which allows me to shave off the checks for the directories.