Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next steps #11

Closed
addyosmani opened this issue May 2, 2017 · 9 comments
Closed

Next steps #11

addyosmani opened this issue May 2, 2017 · 9 comments

Comments

@addyosmani
Copy link
Collaborator

Where should this live?

@yyx990803 Do we want to keep the PWA template on the vuejs org or on the templates org?

What do we want the template package to be called?

vue-cli-template-pwa?

Where should we call out the template on the Vue site?

Should we add an extra note to https://vuejs.org/v2/guide/installation.html#CLI saying this is available or would a dedicated PWA page on the Vue site be better?

cc @sdras in case she has any thoughts on this too.

@sdras
Copy link

sdras commented May 2, 2017

Personally, I think this is an amazing resource and should be highlighted in as many places as possible- I would love it to be in the installation guide.

vue-cli-template-pwa makes sense but I think template is implied in cli, so perhaps vue-cli-pwa would be cleaner and easier to remember.

Exciting! Great work! 🌟

@yyx990803
Copy link
Contributor

I'm on vacation this week - will be working on some CLI polishing after getting back and figure out what to do next :)

@stephane
Copy link

stephane commented May 8, 2017

Do you think it's possible to extend the webpack template with this template features to offer two new options at init time?

  1. manifest file
  2. SW precache

@addyosmani
Copy link
Collaborator Author

Evan and I had a productive call about next steps yesterday (including adding these features into the default template).

For the short term we're going to keep this template separate but explore how we can make the default template output a PWA during the summer.

Evan is going to move this repo over to the templates organization, look at any further changes that need to be made and we'll then look at releasing.

@CharlesOkwuagwu
Copy link

@addyosmani how can we use this template today? These steps below from https://github.com/vuejs/pwa#usage don't exactly tell us how to use this PWA template

$ npm install -g vue-cli
$ vue init webpack my-project
$ cd my-project
$ npm install
$ npm run dev

@addyosmani
Copy link
Collaborator Author

addyosmani commented May 12, 2017 via email

@willbrowningme
Copy link

@CharlesOkwuagwu You can download the repository zip to your PC. Unzip the folder and then run
vue init /path/to/downloaded/folder my-project
This worked for me to try it out, got a 94 lighthouse score on a server with https.

@CodinCat
Copy link
Contributor

CodinCat commented May 15, 2017

vue-cli does support any template on GitHub. There is no need to download the zip, you can initiate a project by this command:

vue init vuejs/pwa my-project

@addyosmani
Copy link
Collaborator Author

Now that the template has been officially launched, we're going to close this issue up. Please feel free to file bugs for any specific behavior that isn't working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants