Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary options from .babelrc #1004

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

anubhav7495
Copy link
Contributor

Removed unnecessary target.browsers property from babel-preset-env as browserslist is already configured in package.json

@LinusBorg
Copy link
Contributor

That makes sense, but I'm unsure in which place to keep it. It might fit better in babelrc, but I think I remeber that the browserList field in package.json can be used by other tools? Do you know anything about that?

@anubhav7495
Copy link
Contributor Author

yeah, browserslist field can be used by Autoprefixer, Stylelint & babel-preset-env.

@LinusBorg
Copy link
Contributor

Thanks. Will merge this tonight when I do some cleanup.

@LinusBorg
Copy link
Contributor

Thanks!

sudo-suhas added a commit to sudo-suhas/webpack that referenced this pull request Nov 18, 2017
sudo-suhas added a commit to sudo-suhas/webpack that referenced this pull request Nov 21, 2017
LinusBorg pushed a commit that referenced this pull request Dec 9, 2017
LinusBorg added a commit that referenced this pull request Dec 11, 2017
* develop:
  remove unnecessary exceptions
  bump version to 1.2.6
  Add JX support (close #1146)
  Automatically install Dependencies and fix lint errors (#1133)
  Set `allChunks: true` by default (close #1110) (#1149)
  airbnb eslint config compatibility with vuex (#1003)
  Document babel target env configuration (#1144)
  Revert "remove uneccessary target.browsers (#1004)" (#1083)
  fix filename of `.eslintignore` (#1136)
  webpack.conf.js is not needed in jest and e2e (#1135)

# Conflicts:
#	template/test/e2e/custom-assertions/elementCount.js
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
options are already defined in package.json's "browserList" field.
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
* develop:
  remove unnecessary exceptions
  bump version to 1.2.6
  Add JX support (close vuejs-templates#1146)
  Automatically install Dependencies and fix lint errors (vuejs-templates#1133)
  Set `allChunks: true` by default (close vuejs-templates#1110) (vuejs-templates#1149)
  airbnb eslint config compatibility with vuex (vuejs-templates#1003)
  Document babel target env configuration (vuejs-templates#1144)
  Revert "remove uneccessary target.browsers (vuejs-templates#1004)" (vuejs-templates#1083)
  fix filename of `.eslintignore` (vuejs-templates#1136)
  webpack.conf.js is not needed in jest and e2e (vuejs-templates#1135)

# Conflicts:
#	template/test/e2e/custom-assertions/elementCount.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants