Fix(computed): destroy helper vm of computed to prevent memleak (fix #270) #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upon host component destroy. avoids a memory leak. fix #270
LinusBorg
changed the title
posva
previously approved these changes
Mar 13, 2020
|
As just discussed on Dicsord, this might break stuff in specific cirtumstances. We should not merge this now and do further investigations. |
|
This won't work. It will break any computed refs that are meant to persist after their original component has been destroyed. Will close and investigate other possible ways. |
|
Reopened, see here: #270 (comment) |
|
It seems this pr has been waiting for a long time to be merged. |
Merged
antfu
approved these changes
Jun 6, 2020
There was a problem hiding this comment.
Maybe we can get this merged?
I think shared computed should be declared outside of a vm's lifecycle, so the problem blocking this might not exist. (mentioned in #270 (comment)) Any thoughts?
|
Yeah I think it's fine as well @antfu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a Vue instancefor each computed(), as a helper to actually use Vue's
computed:option.However we don't destroy it when the host component is destroyed. When the computed property references reactive state that's external to the host instance, the helper instance stays in memory as it's watching the external state.
Properly destroying witht the host component fixes this.
fix #270