Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): require <template> or <script> in SFC #6781

Merged
merged 3 commits into from Nov 8, 2022

Conversation

shengxinjing
Copy link
Contributor

fix #6676

@antfu antfu changed the title fix(compiler-sfc): Single file Component at least has a <template> or… fix(compiler-sfc): require <template> or <script> in SFC Oct 3, 2022
packages/compiler-sfc/src/parse.ts Outdated Show resolved Hide resolved
antfu
antfu approved these changes Oct 3, 2022
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM. Though I think the message could be improved.

@shengxinjing
Copy link
Contributor Author

English is a little hard for me. haha 😃

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 505b35c
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6369cc42d771bd00091eda53

@yyx990803 yyx990803 merged commit a0c7f27 into vuejs:main Nov 8, 2022
8 of 9 checks passed
@shengxinjing shengxinjing deleted the warn6676 branch Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output an error when <template> nor <script> is included in SFC when parsing
3 participants