Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default render function name for ssr #402

Merged
merged 1 commit into from Oct 22, 2020
Merged

Conversation

@meteorlxy
Copy link
Member

@meteorlxy meteorlxy commented Oct 22, 2020

Changes proposed in this pull request:

  • The default templateImport should also be aware of the isServer flag

Similar to https://github.com/vuejs/vue-loader/blob/a56585e707a69de41a1fd083f5f2018e271d1e1c/src/index.ts#L155

/ping @znck

@meteorlxy
Copy link
Member Author

@meteorlxy meteorlxy commented Oct 22, 2020

...OMG, These codes seem to be useless because of #387

@znck
znck approved these changes Oct 22, 2020
@znck znck merged commit 714afd7 into vuejs:next Oct 22, 2020
1 check failed
1 check failed
ci/circleci: Build Error Your tests failed on CircleCI
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants