fix: make get() return type adhering to its return type #191
Conversation
angelogulina
force-pushed
the
176-remove-exists-from-get-retur-type
branch
from
1764f8b to
f7af4a3
Compare
src/vueWrapper.ts
Outdated
| import { find } from './utils/find' | ||
| import { isFunctionalComponent } from './utils' | ||
|
|
||
| type NonexistentDomWrapper<T extends Element> = Omit<DOMWrapper<T>, 'exists'> |
There was a problem hiding this comment.
nit: the name NonexistentDomWrapper sounds a bit weird to me. To my french ear, it sounds like the DomWrapper does not exist 😅 I think we should name it differently, but I don't have a great suggestion...
There was a problem hiding this comment.
I had the same thought... if anything this should ExistsDomWrapper or NotNullableDomWrapper.
Since this type is not used much, could we just inline it?
get<K extends keyof HTMLElementTagNameMap>(
selector: K
): ): Omit<<HTMLElementTagNameMap[K]>, 'exists'>
^ Probably wrong but that would be the idea.
src/vueWrapper.ts
Outdated
| import { find } from './utils/find' | ||
| import { isFunctionalComponent } from './utils' | ||
|
|
||
| type NonexistentDomWrapper<T extends Element> = Omit<DOMWrapper<T>, 'exists'> |
There was a problem hiding this comment.
I had the same thought... if anything this should ExistsDomWrapper or NotNullableDomWrapper.
Since this type is not used much, could we just inline it?
get<K extends keyof HTMLElementTagNameMap>(
selector: K
): ): Omit<<HTMLElementTagNameMap[K]>, 'exists'>
^ Probably wrong but that would be the idea.
angelogulina
force-pushed
the
176-remove-exists-from-get-retur-type
branch
from
f7af4a3 to
351157c
Compare
|
@lmiller1990 @cexbrayat thanks for the suggestions! Making it inline removes the problem regarding the name, which is cool! |
|
Love it, great job. |
3 participants
Refers to this
This MR suggests to improve the guideline that
get()should (and cannot) be used in combination withexists()by removing it from its return type.The following changes only affect TS users as they will now see an error when using
exists()on the returnedget()result (it's assumed that whenget()cannot find an element, it will just throw). They will need to update the code to usefind()which is the official recommendation.