Skip to content

fix: make get() return type adhering to its return type #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020
+7 −7
Merged

fix: make get() return type adhering to its return type #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/vueWrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,12 @@ export class VueWrapper<T extends ComponentPublicInstance> {

get<K extends keyof HTMLElementTagNameMap>(
selector: K
): DOMWrapper<HTMLElementTagNameMap[K]>
): Omit<DOMWrapper<HTMLElementTagNameMap[K]>, 'exists'>
get<K extends keyof SVGElementTagNameMap>(
selector: K
): DOMWrapper<SVGElementTagNameMap[K]>
get<T extends Element>(selector: string): DOMWrapper<T>
get(selector: string): DOMWrapper<Element> {
): Omit<DOMWrapper<SVGElementTagNameMap[K]>, 'exists'>
get<T extends Element>(selector: string): Omit<DOMWrapper<T>, 'exists'>
get(selector: string): Omit<DOMWrapper<Element>, 'exists'> {
const result = this.find(selector)
if (result instanceof DOMWrapper) {
return result
Expand Down Expand Up @@ -169,13 +169,13 @@ export class VueWrapper<T extends ComponentPublicInstance> {

getComponent<T extends ComponentPublicInstance>(
selector: new () => T
): VueWrapper<T>
): Omit<VueWrapper<T>, 'exists'>
getComponent<T extends ComponentPublicInstance>(
selector: FindComponentSelector
): VueWrapper<T>
): Omit<VueWrapper<T>, 'exists'>
getComponent<T extends ComponentPublicInstance>(
selector: any
): VueWrapper<T> {
): Omit<VueWrapper<T>, 'exists'> {
const result = this.findComponent(selector)

if (result instanceof VueWrapper) {
Expand Down