feat: getComponent #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a `getComponent` which returns a `VueWrapper` or throws. It offers two benefits: - a symetric API for components/elements with `findComponent/findAllComponents/getComponent`/`find/findAll/get` - a better experience for TS users (as `findComponent` returns a union type, you can't chain certain things until you disambiguated the type manually). I also refactored the signatures of `find` to offer proper overloads (the current version breaks tests compilation in a real app, i hope this fixes it). I added TSD tests to ensure the inference is working properly.
|
I had this exact thought the other day - I think this makes sense. We have I see you didn't include I will wait for at least one more approval on this PR, to let others have input as well 👍 An aside: testing types is a very cool concept I just learned about recently. |
lmiller1990
requested review from
JessicaSachs,
afontcu,
dobromir-hristov and
lmiller1990
lmiller1990
approved these changes
Apr 24, 2020
afontcu
reviewed
Apr 24, 2020
afontcu
reviewed
Apr 24, 2020
afontcu
approved these changes
Apr 24, 2020
|
@lmiller1990 👍 Thank you for the quick review. @afontcu I pushed a new commit with your suggestion for |
|
Nice, I will do a new alpha this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
getComponentwhich returns aVueWrapperor throws.It offers two benefits:
findComponent/findAllComponents/getComponent/find/findAll/getfindComponentreturns a union type, you can't chain certain things until you disambiguated the type manually).I also refactored the signatures of
findto offer proper overloads (the current version breaks tests compilation in a real app, i hope this fixes it). I added TSD tests to ensure the inference is working properly.