Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix generating README.md #4484

Closed
wants to merge 1 commit into from

Conversation

@zrh122
Copy link
Contributor

commented Aug 22, 2019

Close #4478 .

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@sodatea
sodatea approved these changes Sep 2, 2019
@sodatea

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Thanks for the PR but I just realized this commit did not solve the root cause of the issue and #4525 is a better fix. So I have to close this one. Thanks anyway.

@sodatea sodatea closed this Sep 2, 2019

@zrh122 zrh122 deleted the zrh122:fix-gen-readme branch Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.