Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the nonexistent `test` command from generated README #4525

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@cexbrayat
Copy link
Contributor

commented Aug 30, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

The generated README was mentionning:

### Run your tests
```
npm run test
```

but npm run test throws:

Error: no test specified

This removes the mention of this command from the generated README.

@cexbrayat cexbrayat force-pushed the cexbrayat:fix/readme-test branch 2 times, most recently from 0d06dfe to fffe805 Aug 30, 2019

fix: remove test from readme
The generated README was mentionning:

    ### Run your tests
    ```
    npm run test
    ```

but `npm run test` throws:

    Error: no test specified

This removes the mention of this command from the generated README.

@cexbrayat cexbrayat force-pushed the cexbrayat:fix/readme-test branch from fffe805 to 8809aca Sep 1, 2019

@sodatea
sodatea approved these changes Sep 2, 2019

@sodatea sodatea changed the title fix: remove test from readme fix: remove the nonexistent `test` command from generated README Sep 2, 2019

@sodatea sodatea merged commit 267aa67 into vuejs:dev Sep 2, 2019

7 checks passed

ci/circleci: cli-ui Your tests passed on CircleCI!
Details
ci/circleci: group-1 Your tests passed on CircleCI!
Details
ci/circleci: group-2 Your tests passed on CircleCI!
Details
ci/circleci: group-3 Your tests passed on CircleCI!
Details
ci/circleci: group-4 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@sodatea sodatea added the PR: Bug Fix label Sep 2, 2019

@sodatea sodatea referenced this pull request Sep 2, 2019
2 of 9 tasks complete
@vue-bot

This comment has been minimized.

Copy link

commented Sep 2, 2019

Hey @cexbrayat, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@cexbrayat cexbrayat deleted the cexbrayat:fix/readme-test branch Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.