Fix: bugs about the parent property of nodes

Author: mysticatea

src/script/index.ts

@@ -271,6 +271,12 @@ export function parseVForExpression(code: string, locationCalculator: LocationCa
         right,
     }
 
+    // Modify parent.
+    for (const l of left) {
+        l.parent = expression
+    }
+    right.parent = expression
+
     // Remvoe `for` `(` `let` `)` `;`.
     tokens.shift()
     tokens.shift()
@@ -331,6 +337,11 @@ export function parseVOnExpression(code: string, locationCalculator: LocationCal
     const tokens = ast.tokens || []
     const comments = ast.comments || []
 
+    // Modify parent.
+    for (const b of body) {
+        b.parent = expression
+    }
+
     // Remvoe braces.
     tokens.shift()
     tokens.pop()

src/template/index.ts

@@ -292,7 +292,7 @@ export function convertToDirective(code: string, parserOptions: any, locationCal
             expression: ret.expression,
             references: ret.references,
         }
-        directive.value.parent = directive
+        ret.expression.parent = directive.value
 
         for (const variable of ret.variables) {
             node.parent.parent.variables.push(variable)
@@ -367,6 +367,7 @@ export function processMustache(parserOptions: any, globalLocationCalculator: Lo
 
         node.expression = ret.expression
         node.references = ret.references
+        ret.expression.parent = node
 
         replaceTokens(document, {range}, ret.tokens)
         insertComments(document, ret.comments)

test/ast.js

@@ -12,6 +12,7 @@
 const assert = require("assert")
 const fs = require("fs")
 const path = require("path")
+const lodash = require("lodash")
 const parser = require("..")
 const linter = require("./fixtures/eslint").linter
 
@@ -67,7 +68,6 @@ function getAllTokens(ast) {
 /**
  * Create simple tree.
  * @param {string} source The source code.
- * @param {ASTNode} ast The root node.
  * @returns {object} Simple tree.
  */
 function getTree(source) {
@@ -106,6 +106,41 @@ function getTree(source) {
     return root.children
 }
 
+/**
+ * Validate the parent property of every node.
+ * @param {string} source The source code.
+ * @returns {void}
+ */
+function validateParent(source) {
+    const stack = []
+
+    linter.reset()
+    linter.defineRule("validateparent", (ruleContext) => {
+        ruleContext.parserServices.registerTemplateBodyVisitor(ruleContext, {
+            "*"(node) {
+                if (stack.length >= 1) {
+                    assert(node.parent === lodash.last(stack))
+                }
+                stack.push(node)
+            },
+            "*:exit"() {
+                stack.pop()
+            },
+        })
+        return {}
+    })
+    linter.verify(
+        source,
+        {
+            parser: PARSER,
+            parserOptions: {ecmaVersion: 2017},
+            rules: {validateparent: "error"},
+        },
+        undefined,
+        true
+    )
+}
+
 //------------------------------------------------------------------------------
 // Main
 //------------------------------------------------------------------------------
@@ -174,6 +209,10 @@ describe("Template AST", () => {
 
                 assert.strictEqual(actualText, expectedText)
             })
+
+            it("should have correct parent properties.", () => {
+                validateParent(source)
+            })
         })
     }
 })