Skip to content

Conversation

privatenumber
Copy link
Contributor

@privatenumber privatenumber commented Nov 13, 2020

Updated app.unmount() type declaration.

unmount() doesn't actually take in any parameters, but the type declaration claimed that it does.

close #2922

@posva posva added the ready to merge The PR is ready to be merged. label Jan 4, 2021
@LinusBorg LinusBorg added scope: types 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Feb 1, 2021
@LinusBorg LinusBorg merged commit 18b0c9a into vuejs:master Feb 3, 2021
IanVS added a commit to storybookjs/storybook that referenced this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy between code and documentation (also header) of app.unmount
4 participants