Skip to content

Conversation

@underfin
Copy link
Member

No description provided.

@LinusBorg LinusBorg added the ready to merge The PR is ready to be merged. label Dec 31, 2020
@yyx990803 yyx990803 merged commit 4d9bcb7 into vuejs:master Jan 5, 2021
@underfin underfin deleted the production-devtools branch January 6, 2021 02:33
@andrewcourtice
Copy link

@LinusBorg @yyx990803

Just checking - is the __VUE_PROD_DEVTOOLS__ flag now required to be defined in production builds? Just ran a production build (using webpack) after bumping to v3.0.6 and this error came up.

image

I haven't defined the __VUE_PROD_DEVTOOLS__ global in my build config but that wasn't an issue up to v3.0.5. Should I always be defining this global or is this a regression in v3.0.6?

Cheers 👍

@yyx990803
Copy link
Member

yyx990803 commented Feb 24, 2021

It was unintended - already fixed in d0ea745

For now the workaround is to explicitly define __VUE_PROD_DEVTOOLS__ (which is recommended anyway)

@andrewcourtice
Copy link

@yyx990803 Excellent! Thanks for the quick reply and fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge The PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants