Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return nextTick from setters, fix #1515 #1517

Merged
merged 10 commits into from Apr 27, 2020

Conversation

@dobromir-hristov
Copy link
Collaborator

@dobromir-hristov dobromir-hristov commented Apr 26, 2020

Return nextTick from all setter methods.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
closes #1515

@lmiller1990 lmiller1990 self-requested a review Apr 27, 2020
Copy link
Member

@lmiller1990 lmiller1990 left a comment

nicely done, thanks for updating the docs. looks like this was quite a bit of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants