Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optionally hide deprecation errors #1518

Merged
merged 3 commits into from Apr 27, 2020
Merged

Conversation

@dobromir-hristov
Copy link
Collaborator

@dobromir-hristov dobromir-hristov commented Apr 26, 2020

Allows users to hide the deprecation warnings and hides them while our internal tests are run.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lmiller1990 lmiller1990 merged commit 7a0b7e0 into dev Apr 27, 2020
6 checks passed
@lmiller1990 lmiller1990 deleted the feat/hide-deprecation-errors branch Apr 27, 2020
@fredicious
Copy link

@fredicious fredicious commented May 6, 2020

Allows users to hide the deprecation warnings

What would be the way to do that ? the config showDeprecationWarnings doesn't seem to be supported yet

@lmiller1990
Copy link
Member

@lmiller1990 lmiller1990 commented May 6, 2020

@fredicious it should work - did you do this:

import { config } from '@vue/test-utils'
config.showDeprecationWarnings = false

In your test setup file? It should disable for all the tests.

@fredicious
Copy link

@fredicious fredicious commented May 6, 2020

that worked, thanks a lot @lmiller1990
Somehow I got confused between the main config and the mounting options.

@sullivanpt sullivanpt mentioned this pull request May 20, 2020
@@ -1,6 +1,7 @@
// @flow
import Vue from 'vue'
import semver from 'semver'
import { config } from '@vue/test-utils'

Not sure why, but this new import here breaks the IIFE. Would love some help tracking this down and fixing it. See #1553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants