Implements plugin parameters #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,10 +66,15 @@ ViewModel.use = function (plugin) { | |||
| return utils.warn('Cannot find plugin: ' + plugin) | |||
| } | |||
| } | |||
|
|
|||
| // additional parameters | |||
| var args = Array.prototype.slice.call(arguments, 1) | |||
There was a problem hiding this comment.
Why slice then unshift here? It seems simply plugin.install.apply(plugin, arguments) will do.
There was a problem hiding this comment.
Because I want to replace arguments[0] with ViewModel (otherwise, arguments[0] is the plugin function / string / object), and arguments[0] cannot be reassigned.
There was a problem hiding this comment.
Oh you're right, I was reading the code out of context...
There was a problem hiding this comment.
Can you use [].slice here? This function is not perf sensitive and it could save a few bytes :)
There was a problem hiding this comment.
Sure! I was using Array.prototype.slice for performance reasons, but you are right :)
yyx990803
added a commit
that referenced
this pull request
Feb 20, 2014
Implements plugin parameters
|
Landed! Thanks a lot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change: every additional parameters is passed to the function instead of a single
optionsparam. As a consequence,thisis set to the current ViewModel if the plugin is a function.Tell me if that’s OK, otherwise I will change it to respect what you said in #88. I will also make a pull request on https://github.com/vuejs/vuejs.org.