fix(inject): hasOwn instead of 'in' (fix #7284) #7460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2018 16:20
Symbol polyfill adds a setter on the Object prototype so the 'in' check evaluated to true on every object fix vuejs#7284
Prototype properties were being injected, so injecting 'constructor' would have hit the first provide-layer and not yield expected results. fix vuejs#7284
posva
approved these changes
Jan 16, 2018
This was referenced Mar 14, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
) fix vuejs#7284 * fix(Injection with Symbol polyfill): hasOwn instead of 'in' Symbol polyfill adds a setter on the Object prototype so the 'in' check evaluated to true on every object * test(Injected properties): Ensures prototype properties aren't injected Prototype properties were being injected, so injecting 'constructor' would have hit the first provide-layer and not yield expected results.
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
) fix vuejs#7284 * fix(Injection with Symbol polyfill): hasOwn instead of 'in' Symbol polyfill adds a setter on the Object prototype so the 'in' check evaluated to true on every object * test(Injected properties): Ensures prototype properties aren't injected Prototype properties were being injected, so injecting 'constructor' would have hit the first provide-layer and not yield expected results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was caused by the
inoperator check to see if an injection exists in a parent provide.In the particular Issue, the injection didn't work because the the Symbol polyfill adds a setter to the Object prototype for every Symbol created and the
in-operator check evaluated to true on any object inheriting Object. DemoHowever, I'm thinking the implications of using
inmay be further reaching as it could have been any native prototype property. Here I demonstrate using the string'constructor'leads to unexpected injection behavior.Although this fixes #7284, I am framing this as a fix for prototype properties being injected.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: