Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vuepress dev <projectDir> goes ahead even if the directory doesn't exist #1521

Closed
1 task done
open-source-explorer opened this issue Apr 5, 2019 · 3 comments
Closed
1 task done

vuepress dev <projectDir> goes ahead even if the directory doesn't exist #1521

open-source-explorer opened this issue Apr 5, 2019 · 3 comments

Comments

@open-source-explorer
Copy link

open-source-explorer commented Apr 5, 2019 •
edited
Loading

  • I confirm that this is an issue rather than a question.

Bug report

Steps to reproduce

What is expected?

vuepress dev <directory> should show an appropriate warning if the directory doesn't exist.

What is actually happening?

The default template is being served.

System:
OS: Linux 4.18 Ubuntu 18.10 (Cosmic Cuttlefish)
CPU: (4) x64 Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
Shell: 4.4.19 - /bin/bash
Binaries:
Node: 8.11.4 - /usr/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm
Browsers:
Chrome: 73.0.3683.75
Firefox: 66.0.2
@open-source-explorer open-source-explorer changed the title vuepress dev <projectDir> goea ahead even if the directory doesn't exist vuepress dev <projectDir> goes ahead even if the directory doesn't exist Apr 5, 2019
@open-source-explorer
Copy link
Author

@ulivz Your thoughts?

@ulivz
Copy link
Member

ulivz commented Apr 6, 2019

Maybe we should emit warning instead of an error since a VuePress application can be all composed with dynamic additionalPages.

@ulivz ulivz closed this as completed in 6da9a5f Apr 6, 2019
@ulivz
Copy link
Member

ulivz commented Apr 6, 2019 •
edited
Loading

Updated at 6da9a5f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ulivz @open-source-explorer